Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly deal with </font> #385

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Jojo-Schmitz
Copy link
Owner

@Jojo-Schmitz Jojo-Schmitz commented Mar 18, 2024

instead of ignoring it altogether, reset font face and -size back to what it was before <font ...>.
While at it add the tags for strikeout, as possible in Mu4 already.

Also fix some code warnings shown by QtCreator.

'Backport' of musescore#21972 (actually this here existed first)

@Jojo-Schmitz Jojo-Schmitz force-pushed the 3x-revert-font_face_and_size branch 2 times, most recently from 29a15da to 298cf1c Compare March 23, 2024 11:08
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3x-revert-font_face_and_size branch 13 times, most recently from 6b7b002 to 0725eaa Compare April 7, 2024 11:20
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3x-revert-font_face_and_size branch from 0725eaa to c10c1cd Compare April 10, 2024 08:22
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 3 times, most recently from 9164f41 to abc8ede Compare June 18, 2024 14:16
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3x-revert-font_face_and_size branch from c10c1cd to e06da2d Compare August 28, 2024 15:25
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 2 times, most recently from bf247bf to 922a518 Compare December 23, 2024 13:25
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3x-revert-font_face_and_size branch from e06da2d to 5aefa4e Compare December 28, 2024 14:02
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 2 times, most recently from 9326c7c to 88927e8 Compare January 6, 2025 11:42
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 19 times, most recently from e03471a to a4d9423 Compare January 10, 2025 20:38
instead of ignoring it altogether, reset font face and -size back to what it was before `<font ...>`.
While at it add the tags for strikeout, as possible in Mu4 already.

Also fix some code warnings shown by QtCreator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant