Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH#19669: Enable 2nd adjustment for cross staff beamed notes #219

Draft
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Jojo-Schmitz
Copy link
Owner

@Jojo-Schmitz Jojo-Schmitz commented Oct 26, 2023

Backport of musescore#19831

Resolves: musescore#19669

@Jojo-Schmitz Jojo-Schmitz marked this pull request as draft October 26, 2023 15:40
@Jojo-Schmitz Jojo-Schmitz deleted the branch 3.x December 1, 2023 08:15
@Jojo-Schmitz Jojo-Schmitz reopened this Dec 1, 2023
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-cross-beam-collision branch 3 times, most recently from d76ade1 to 39e7f95 Compare April 14, 2024 13:25
@Jojo-Schmitz
Copy link
Owner Author

Jojo-Schmitz commented Apr 14, 2024

Very same code changes, but doesn't do the same improvement :-(
And something is wrong with the vtest, it shouldn't succeed, it should look like this (created with Mu4):
cross-8-ref
But does come out like this
cross-8-ref
basically the same as without this PR

Lesson learned: all tests passing doesn't mean too much :-(

@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-cross-beam-collision branch from 0bcd144 to f1383e0 Compare February 23, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants