[Bug]: Manual install title is wrong in non-English

[sbruens]

Application

Outline Manager

Describe the bug

We're doing string replacement in the manual installation title, but are not always providing a value, which is bad. For non-Cloud Provider setup we shouldn't leverage the same translation message.

Steps to reproduce

1. Open the Manager
2. Change to non-English language
3. Set up manual server

What did you expect to happen?

No response

What actually happened?

Panel title is cut off because the Cloud Provider is an empty string, which doesn't make sense in the message in non-English languages.

Outline Version

1.16.0

What operation system are you using?

macOS

Operating System Version

No response

Screenshots and Videos

[Arnesh-pal]

I'd be happy to help!
Could you share more details about the issue?

[sbruens]

@Arnesh-pal thanks for offering to help! We appreciate contributions.

In the Manager, click the "Advanced - Set up Outline anywhere" panel. This page has the title "These steps will help you install Outline on a Linux server." but in other languages this is incorrect.

This is because we try and re-use the message for all installation panels, using a parameter cloudProvider in the message. See the message:

outline-apps/server_manager/messages/en.json

Line 161 in 29ba74f

"manual-server-description": "These steps will help you install Outline on a {cloudProvider} Linux server.",

and where we use it:

outline-apps/server_manager/www/ui_components/outline-manual-server-entry.ts

Lines 201 to 204 in 29ba74f

	<span slot="step-description"
	>[[localize('manual-server-description', 'cloudProvider',
	cloudProviderName)]]</span
	>

For all other panels (GCP, DigitalOcean, etc.) this makes sense, but for a manual install we use an empty string for cloudProvider. This genitive case happens to work in English, but it doesn't work in other languages. We should use a dedicated message for this that doesn't expect any cloudProvider message.