-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements to the Numbers page #4649
Conversation
4aaceaa
to
9767912
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are looking much better! Thanks!
I have mostly minor comments about coding style and wording. Please take a look 🙏
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
# Conflicts: # docs/topics/numbers.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Just a few minor comments for you to consider 🙏
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
Bad samples fun main() {
//sampleStart
val x = 5L / 2
println (x == 2)
// Error, as Long (x) cannot be compared to Int (2)
println(x == 2L)
// true
//sampleEnd
} (3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'. |
1 similar comment
Bad samples fun main() {
//sampleStart
val x = 5L / 2
println (x == 2)
// Error, as Long (x) cannot be compared to Int (2)
println(x == 2L)
// true
//sampleEnd
} (3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'. |
No description provided.