Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception from the plugin: executing git command from EDT #8

Open
juliabeliaeva opened this issue Jul 24, 2019 · 4 comments
Open

Exception from the plugin: executing git command from EDT #8

juliabeliaeva opened this issue Jul 24, 2019 · 4 comments
Assignees
Labels
bug Something isn't working important Label for important issues

Comments

@juliabeliaeva
Copy link

java.lang.Throwable: Synchronous execution on EDT: /usr/bin/git -c core.quotepath=false -c log.showSignature=false rev-list HEAD --count "--since=\"last month\""
	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:145)
	at com.intellij.execution.process.OSProcessHandler.checkEdtAndReadAction(OSProcessHandler.java:118)
	at com.intellij.execution.process.OSProcessHandler.waitFor(OSProcessHandler.java:63)
	at git4idea.commands.GitTextHandler.waitForProcess(GitTextHandler.java:145)
	at git4idea.commands.GitHandler.runInCurrentThread(GitHandler.java:383)
	at git4idea.commands.GitImplBase.doRun(GitImplBase.java:172)
	at git4idea.commands.GitImplBase.run(GitImplBase.java:148)
	at git4idea.commands.GitImplBase.runCommand(GitImplBase.java:46)
	at git4idea.commands.GitImpl.runCommand(GitImpl.java:41)
	at processing.GitCommitsProcessor.lambda$processGitHistory$5(GitCommitsProcessor.java:94)
	at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:308)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:433)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:416)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:399)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:935)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:812)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:471)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:705)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:470)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
@svitkovsergey
Copy link
Collaborator

Thanks, I'll take a look at it!

@svitkovsergey
Copy link
Collaborator

As I see, this could be related to bug in IDEA 2019.2.
flutter/flutter-intellij#3697
https://youtrack.jetbrains.com/issue/CPP-16090
flutter/flutter-intellij#3697

I'll add better logging (in order to get more details if this repeats) and release a new version of plugin on this or next weekend.

@svitkovsergey svitkovsergey self-assigned this Aug 5, 2019
@juliabeliaeva
Copy link
Author

I think the problem is that VcsInitialization invokes all the tasks in the EDT if they were added after the initialization is finished. Perhaps, initialization requests should only be used for initialization, and not for normal operations.

@svitkovsergey
Copy link
Collaborator

OK, thanks a lot! I'll fix this soon. 👍

@svitkovsergey svitkovsergey added bug Something isn't working important Label for important issues labels Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important Label for important issues
Projects
None yet
Development

No branches or pull requests

2 participants