Fix for #5 #6
Open
Fix for #5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the reference counting on libssh2_init() and libssh2_exit() If a instance of Ssh2Client is ever created, then connection is mad with QCoreApplication to exit libssh2 using libssh2_exit()
Switched from channel_send_eof() to channel_close() fixes the exitcode issue
|
Thank you for all the PR's! Next week I'll have time to look at it. |
Fixed grammer in error message
In Qt6 QIODevice now uses ringbuffer for reading data, they're allocated with setReadChannelCount(), which is qt private method. Without setting the readChannelCount() connections aren't terminated and when reading stderr for process, QIODevice just crashes when calling readAll().
The crash has to do with disconnection of signal and slots. Qt6 is more strict on using slots after objects have been destroyed. I've changed the ssh2client deconstructor to wait until client is fully disconnected from the QTCPSocket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Ssh2Channel.h and Ssh2Debug.h to src/include