Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping Docker build from main build process #4694

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Allow skipping Docker build from main build process #4694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/storage-backend/scylladb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ mvn clean install -Pjanusgraph-release -Puse-scylla -DskipTests=true --batch-mod
///

This command will generate distribution builds (both normal and full distribution build) in the
following directory: `janusgraph-dist/target/`.
following directory: `janusgraph-dist/target/` as well as build local JanusGraph Docker image.
If you don't have Docker installed or wish to avoid Docker image build process you can pass `-Pskip-docker`
(notice, all tests are automatically disabled when this flag is used).

Otherwise, if you can't build distribution on your own, you can use the JanusGraph provided distribution and replace
the following libraries in `lib` directory (all libraries can be downloaded via Maven Central Repository).
Expand Down
10 changes: 10 additions & 0 deletions janusgraph-dist/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
<skipDefaultDistroIT>${it.skip}</skipDefaultDistroIT>

<doc.dir>${project.parent.basedir}/docs</doc.dir>
<docker.build.skip>false</docker.build.skip>

<cql-module>janusgraph-cql</cql-module>
<cql-hadoop-module>cassandra-hadoop-util</cql-hadoop-module>
Expand Down Expand Up @@ -363,6 +364,13 @@
<cql-hadoop-module>scylla-hadoop-util</cql-hadoop-module>
</properties>
</profile>
<profile>
<id>skip-docker</id>
<properties>
<docker.build.skip>true</docker.build.skip>
<skipTests>true</skipTests>
</properties>
</profile>
<profile>
<id>janusgraph-release</id>
<dependencies>
Expand Down Expand Up @@ -636,6 +644,7 @@
<goal>exec</goal>
</goals>
<configuration>
<skip>${docker.build.skip}</skip>
<executable>./docker/build-and-push-image.sh</executable>
<workingDirectory>${project.basedir}</workingDirectory>
<arguments>
Expand Down Expand Up @@ -669,6 +678,7 @@
<goal>exec</goal>
</goals>
<configuration>
<skip>${docker.build.skip}</skip>
<executable>./docker/build-and-push-image.sh</executable>
<workingDirectory>${project.basedir}</workingDirectory>
<arguments>
Expand Down
Loading