Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable janusgraph-core unit tests in CI #4158

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

cdegroc
Copy link
Contributor

@cdegroc cdegroc commented Nov 30, 2023

Add a new Github action for janusgraph-core unit tests
FI janusgraph-core unit tests will fail until #4140 is merged.


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@cdegroc cdegroc force-pushed the enable-core-unit-tests branch from 1ca45db to 38b7f39 Compare November 30, 2023 14:47
@cdegroc cdegroc changed the title Enable unit test for janusgraph-core Enable janusgraph-core unit tests in CI Nov 30, 2023
@porunov
Copy link
Member

porunov commented Nov 30, 2023

#4140 is now merged. Could you please rebase this PR?

Signed-off-by: Clement de Groc <clement.degroc@datadoghq.com>
@cdegroc cdegroc force-pushed the enable-core-unit-tests branch from 38b7f39 to ab1b1dc Compare November 30, 2023 16:41
@cdegroc
Copy link
Contributor Author

cdegroc commented Nov 30, 2023

Rebased on master/HEAD

@cdegroc cdegroc marked this pull request as ready for review November 30, 2023 16:51
@porunov porunov added this to the Release v1.1.0 milestone Dec 1, 2023
@porunov porunov merged commit d2a3854 into JanusGraph:master Dec 1, 2023
1 check passed
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants