Update monkeypatch to fix (many) line numbers being off due to decorators #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a complicated problem and is not fully resolved, but this seems to be improvement over the simple adjustment in the previous logic. The old logic was doing a simple shift on the line numbers, and it seemed to fix the problem if a function was lower in the file after a function that had a single decorator.
For example:
In all other cases the line numbers would be wrong. With this new fix, I'm seeing most cases being correct except for multiline decorators, but it's easily fixed by altering the function with the wrong line numbers.
See breuleux/jurigged#29 for the full issue discussion.