Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expl3.json with new macros and remove deprecated macros #4148

Closed
wants to merge 2 commits into from

Conversation

mbertucci47
Copy link

This PR updates the expl3.json completion file with new macros provided by l3kernel and removes deprecated macros, including many of the x-type variants. It also puts the macros in alphabetical order which makes the diff difficult to analyze, so apologies for that.

@James-Yu
Copy link
Owner

May I know how this file is generated in this PR? As we essentially use dev/latex3command.py to generate this file, it would be very helpful if you may also update the script.

@mbertucci47
Copy link
Author

Ah I see, now it makes sense why the commands were in seemingly random order. I just updated the json file by hand and haven't taken the time to figure out what the python script is doing. If the script generates an up-to-date json file and simply hasn't been run in a while, then feel free to close this and update the usual way

@James-Yu
Copy link
Owner

The script indeed hasn't been run for some time and may be outdated. Did you use some sort of scripts to generate this file? If so, it would be great for maintenance.

@mbertucci47
Copy link
Author

No, it was very low tech. I literally just alphabetized the existing file with my editor, removed the commands found in l3deprecation.dtx, ran \cs_meaning:N on the remaining ones to see which were undefined and removed those, then added whatever was missing from a quick scan of interface3.

@James-Yu
Copy link
Owner

I'm a bit torn on whether this should be merged. Definitely an improvement but not likely maintainable. What do you think @jlelong ?

@mbertucci47
Copy link
Author

mbertucci47 commented Jan 30, 2024

I was able to run latex3command.py after updating the path in dtx_files for texlive 2023 (soon 2024) and changing expl3.cmds to expl3.macros. It gave the correct list, removing deprecated commands and adding new ones, and as one might expect catching a few that I missed. So I would close this PR and keep the script. I know next to no Python but I'd assume alphabetizing the list wouldn't be that hard?

@jlelong
Copy link
Collaborator

jlelong commented Jan 30, 2024

I have updated the script and added some sorting too. The new completion list has been generated too.
See #4151

@jlelong jlelong closed this Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants