Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE in LootMixin #28

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Prevent NPE in LootMixin #28

merged 9 commits into from
Jun 10, 2024

Conversation

jlortiz0
Copy link
Contributor

@jlortiz0 jlortiz0 commented Apr 6, 2023

It is possible for checkLootInteraction to be called with a null player. This pull request changes LootMixin to use a Random seeded with LootTableSeed like the vanilla function does if the player is null.

In the event that the player is null, this will make hats predictable based on world location.

@JSJBDEV JSJBDEV merged commit 294c215 into JSJBDEV:master Jun 10, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants