Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding POS503 dataset #24

Merged
merged 1 commit into from
Mar 28, 2022
Merged

adding POS503 dataset #24

merged 1 commit into from
Mar 28, 2022

Conversation

oceandie
Copy link
Contributor

No description provided.

@oceandie oceandie requested a review from malmans2 March 28, 2022 15:33
@oceandie
Copy link
Contributor Author

Hi @malmans2,

Not sure why I get that pre-commit failing ... locally it worked perfectly .... any advice :) ?

@malmans2
Copy link
Member

It's this issue: #18
I couldn't figure out how to fix it. Basically, the documentation build by the CI is slightly different than the documentation build locally. Not sure why.

The code is fine though. Up to you, you could switch it off and remove the documentation that is automatically built.

@oceandie
Copy link
Contributor Author

Thanks a lot for looking into this! Trivial question: can I ignore the failing and merge? :)

@malmans2
Copy link
Member

Yup!

@oceandie oceandie merged commit 8558d41 into main Mar 28, 2022
@oceandie oceandie deleted the POS503 branch March 28, 2022 19:56
@malmans2
Copy link
Member

@oceandie I noticed this dataset is missing in the README

@oceandie
Copy link
Contributor Author

Yep, I'll add it today ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants