Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rogue print statement in ini_reader.py #49

Open
rplzzz opened this issue May 14, 2020 · 0 comments · May be fixed by #50
Open

Rogue print statement in ini_reader.py #49

rplzzz opened this issue May 14, 2020 · 0 comments · May be fixed by #50

Comments

@rplzzz
Copy link
Contributor

rplzzz commented May 14, 2020 •
edited
Loading

I found this while tracking down something for Tom:

xanthos/xanthos/data_reader/ini_reader.py

Line 606 in 754f111

print('Warning: {} is not a valid parameter'.format(k))

I believe the best practice would be to change print(...) to logging.warning(...)

Also, I grepped the rest of the source for instances of print, and this is the only one.
rplzzz added a commit to rplzzz/xanthos that referenced this issue May 14, 2020
@rplzzz
Change print to logging.warning in ini_reader.
3fb6865 
Fixes JGCRI#49
@rplzzz rplzzz linked a pull request May 14, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change print to logging.warning in ini_reader. rplzzz/xanthos
1 participant
@rplzzz