Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Development Branch #755

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Active Development Branch #755

wants to merge 13 commits into from

Conversation

kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Oct 22, 2024

Eventually, this PR will be merged into the main and correspond with the a > V3.2 model version release. As of 2/26/2025 this PR contains minor & bug fix behavior changes.

PRs Old-New Test Update? Description
#739, #741 no documentation changes only
#764 yes bug fix changed CO2 concentrations
#773 no expose soil & detritus rh as model output

(IMPORTANT NOTE: this PR documentation will need to be updated to reflect merged PRs)

kdorheim and others added 5 commits February 23, 2024 12:37
Beta = 0.36 seems incorrect, isn't it 0.53.

beta <- fetchvars(core, NA, BETA())
beta
##              scenario year variable value      units
## 1 Unnamed Hector core   NA     beta  0.53 (unitless)

(...)
The current value is set to 0.36 (note that it is a unitless quantity, hence the (unitless) unit).
Fix a minor numeric inconsistency in the hector vignette
* Github Issue 718. Add papers to Hector manuscript lists, including  V3.2.0 manuscript 

* github issue 727. rename FCH4 to RF_CH4 to match all other RF output

* Add a new release checklist

* github issue 734, add output streams

* quite build message

* github issue 740, add matilda refernces

* github issue 735, add ref temperature period to plot
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (f54a92e) to head (1e640c4).

Files with missing lines Patch % Lines
src/simpleNbox.cpp 81.81% 4 Missing ⚠️
src/csv_outputstream_visitor.cpp 0.00% 2 Missing ⚠️
src/rcpp_constants.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   80.53%   80.48%   -0.05%     
==========================================
  Files          61       61              
  Lines        6308     6335      +27     
==========================================
+ Hits         5080     5099      +19     
- Misses       1228     1236       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants