修复发送弹幕BUG #35
Merged
修复发送弹幕BUG #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Izumiko
reviewed
Feb 23, 2024
| @@ -661,9 +663,10 @@ | |||
| const json = await resp.json(); | |||
| if (json.errorCode == 0) { | |||
| const colorStr = `000000${color.toString(16)}`.slice(-6); | |||
| const modemap = { 6: 'ltr', 1: 'rtl', 5: 'top', 4: 'bottom' }[mode]; | |||
There was a problem hiding this comment.
我看API文档那里，mode是个数字，你确定是用rtl这种字符串么？
There was a problem hiding this comment.
往服务器发送的在644行
const danmakuUrl = apiPrefix + 'https://api.dandanplay.net/api/v2/comment/' + window.ede.episode_info.episodeId;
const params = {
'time': time,
'mode': mode,
'color': color,
'comment': danmakuText
};
const resp = await fetch(danmakuUrl, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
'Accept': 'application/json',
'User-Agent': navigator.userAgent,
'Authorization': 'Bearer ' + ddplayStatus.token
},
body: JSON.stringify(params)
});
发的还是数字 但是本地播放器这个是转化成字符串
Izumiko
reviewed
Feb 23, 2024
| if (!sessionInfo[0].NowPlayingItem) { | ||
| await initConfig(); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
这个分支进入的前提是已经获取到认证信息了，再调用initConfig是为了换个新的？
There was a problem hiding this comment.
因为在Safari上切后台再回来 不知道Safari做了什么，会导致无法获取sessionInfo[0].NowPlayingItem 所以从头刷新一遍
而且没拿到sessionInfo[0].NowPlayingItem的话后面的代码会直接卡住
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原本没正常处理mode值导致本地发的弹幕全部变成滚动，重新加载后本地还会变成两条重复弹幕
