feat: extended image download opts #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166, #137, #128
Adds a
resolveImageSrc
callback with type:discord-html-transcripts/src/downloader/images.ts
Lines 6 to 17 in cc95e47
Introduces a
![image](https://private-user-images.githubusercontent.com/14848722/303864590-4e594c37-2974-41ad-9613-42066d63fe30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mzk3MDksIm5iZiI6MTczODkzOTQwOSwicGF0aCI6Ii8xNDg0ODcyMi8zMDM4NjQ1OTAtNGU1OTRjMzctMjk3NC00MWFkLTk2MTMtNDIwNjZkNjNmZTMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE0NDMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3M2VjZTUxMjQ2ZmVkODg0YTc5NWQzMWQyMDVmYmExMGIyMDgxYWJiMjVmNmU2Yzc1NjMzNDJjZjhiMzExZTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8EBF6nScrzZF_3VagSMy0RCGLO1i4LEH3BdLsbfHNC0)
TranscriptImageDownloader
builder:Compression, in my testing, was able to turn a 3.3MB png to a 37KB WebP image with no noticeable quality change unless you really zoom in.
What needs to be done before merging: