Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website- Contains content for all integrated features #151

Open
wants to merge 3 commits into
base: gh-pages-sources
Choose a base branch
from

Conversation

Asiya-Ismail
Copy link
Contributor

Website: Contains content for all integrated features:

Description:

  • Added new md files to the website containing descriptions on what and how to use all the integrated features of the EiffelVis App.
  • Content files were all placed inside the feature-2 folder.
  • To each feature additionally we added gifs with demonstration on how the features are used.
  • All GIFs were put into the images folder inside static

Video:

Website Demo:

website.mov

Testing:

  • Testing was done locally by running hugo server.

Co-authored-by:Kevinayad<kevinayad@hotmail.com>
Co-authored-by:Kevinayad <kevinayad@hotmail.com>
@RuthgerD
Copy link
Collaborator

RuthgerD commented Jan 5, 2023

Whats up with the black bars on the integrated videos?

@Asiya-Ismail
Copy link
Contributor Author

Think that happened when I uploaded the video the original does not contain that

background = "dark"
align = "top"

title = "Timeline"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is bad and will probably go at some point, lets not advertise it for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will do

subtitle= "Graph Options allows you to customise some aspects of the graph to be display in another prefered state. Example: you can change the proximity of the nodes to each other or you could change the shade of colour the nodes have."

[asset]
image = "graph_options.gif"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we upload these gifs to imgur or something instead? I want to avoid artifacts inside the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a little trouble using the gifs uploaded to imgur in the md files, if you have any suggestions on how to do that, please let me know.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url and image here should be replaceable by an imgur direct link, unsure what else could go wrong?

background = "dark"
align = "top"

title = "Node Hover"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have talked about it before, but I suggest using sentences like "Easily highlight events" rather than "Node Hover"; it sounds way more interesting and increases the chance that people will actually read whatever is below

background = "dark"
align = "top"

title = "Graph Options"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here like Karl already said in slack, "Modify how you want to display your graph"

background = "dark"
align = "top"

title = "Legend"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: "All event types at a glance"

background = "dark"
align = "top"

title = "Non-interactive Mode"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: "Watch the pipeline grow with time"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that for the title?

@RuthgerD
Copy link
Collaborator

RuthgerD commented Jan 5, 2023

I think its also missing something about the ability to query specific events

@Asiya-Ismail
Copy link
Contributor Author

How do mean, can you elaborate?

@RuthgerD
Copy link
Collaborator

RuthgerD commented Jan 5, 2023

How do mean, can you elaborate?

I mean there is nothing explaining how you can query for events

@Asiya-Ismail
Copy link
Contributor Author

I see, will try to add that into the filter options feature, or maybe talking about that in its own part. Let me know which one you think is better

@RuthgerD
Copy link
Collaborator

RuthgerD commented Jan 9, 2023

filter options feature

that seems to be missing?

@Asiya-Ismail
Copy link
Contributor Author

The original plan was to wait until the new changes to filter options feature was integrated before adding it in.

@Asiya-Ismail
Copy link
Contributor Author

Also I had posted the gifs to imgur and tried using a url in place of the image path in the md files but the gif no longer shows up. Might be doing it wrong or maybe asset.image can't read urls im not sure what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants