Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to error types and moved some functions into modules #13

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Jan 8, 2024

  • Stopped directly wrapping crypto error messages (like aead::Error) for our own errors
  • Changes the Display impls for each error to be more verbose/human-readable
  • Moved functions from lib.rs into their respective modules (I think they were all v4-related functions)
    • Note that v4::aes is also re-exported into v5::aes
  • Made some functions non-pub, as we don't call them externally, hopefully making our API surface easier to understand next time we visit this repo

@giarc3 giarc3 requested a review from coltfred January 8, 2024 18:03
Copy link

github-actions bot commented Jan 8, 2024

File Coverage Lines
All files 90% 90%
src/v4/aes.rs 97% 97%
src/lib.rs 4% 4%
src/aes.rs 83% 83%
src/v5/key_id_header.rs 86% 86%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 40acdee

Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern about an error.

@giarc3 giarc3 merged commit 39392a5 into main Jan 9, 2024
7 checks passed
@giarc3 giarc3 deleted the error-types-and-rearrange branch January 9, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants