-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize theme #453
Modernize theme #453
Conversation
@Ionaru Change the border color from |
"Modern" is subjective, I don't think we should touch look of the editor until #447. |
Yes, it is subjective. This modification does away with the borders and use a more flat style. Try it and see if you like it. Might be something for the new editor. For the current version might want to consider just changing the border color though, because now it doesn't match with the border color of the |
The editor was never made to integrate perfectly with Bootstrap. The design is purposefully minimal and can be easily edited by website creators to match their website theme. I don't think it's a good idea to copy over all the colours that bootstrap (currently) uses. |
Then consider at least being consistent in the border color that is used, because now EasyMDE uses two different border colors, both |
I agree it's good to be consistent. I'll leave the choice between |
I would prefer But this PR was to modernize the theme and also includes other changes such as flat border-less buttons with more rounded corners. So this PR can be for EasyMDE v3. I opened a new PR that only fixes the inconsistent border color at #466. |
Visual refresh of the theme to modernize it.