Hidden-Friends-Finder broken by urllib3 and requests

[NeolithEra]

Hi, users are unable to run Hidden-Friends-Finder due to dependency conflict with urllib3 package.

As shown in the following full dependency graph of Hidden-Friends-Finder, Hidden-Friends-Finder requires urllib3>=1.24.2，while requests==2.21.0 requires urllib3>=1.21.1,<1.25.

According to pip’s “first found wins” installation strategy, urllib3 1.25.3 is the actually installed version. However, urllib3 1.25.3 does not satisfy urllib3>=1.21.1,<1.25.

Dependency tree

Hidden-Friends-Finder-master
| +-certifi(version range:==2018.11.29)
| +-chardet(version range:==3.0.4)
| +-click(version range:==7.0)
| +-colorama(version range:==0.4.1)
| +-idna(version range:==2.8)
| +-requests(version range:==2.21.0)
| | +-certifi(version range:>=2017.4.17)
| | +-chardet(version range:<3.1.0,>=3.0.2)
| | +-idna(version range:>=2.5,<2.9)
| | +-urllib3(version range:>=1.21.1,<1.25)
| +-selenium(version range:==3.141.0)
| +-tqdm(version range:==4.31.1)
| +-urllib3(version range:>=1.24.2)
| +-wincertstore(version range:==0.2)

Thanks for your help.
Best,
Neolith

[NeolithEra]

Solution

1. Fix your direct dependency to be urllib3>=1.21.1,<1.25.

2. Fix your direct dependency to be requests==2.22.0.

3. Remove your direct dependency urllib3, and use urllib3 transitively introduced by requests.

Which solution do you prefer, 1, 2 or 3?

@musafir-py Please let me know your choice. I can submit a PR to solve this issue.