chore(demo): improve loading views #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgray-instawork
force-pushed
the
hardin/demo-loaders
branch
from
810a12e to
9419d0d
Compare
demo/App.tsx
Outdated
| @@ -49,6 +49,7 @@ export default () => ( | |||
| paddingBottom: insets?.bottom, | |||
| paddingLeft: insets?.left, | |||
| paddingRight: insets?.right, | |||
| paddingTop: Platform.OS === 'ios' ? insets?.top : 0, | |||
There was a problem hiding this comment.
does this cause issues on Android?
There was a problem hiding this comment.
Android didn't show the same jumping and it seems to be pushing the UI down lower than it needs to be. I was getting a value of around 25 for the top on Android simulator.
There was a problem hiding this comment.
ok, it would be worth adding a comment about this for future reference
hgray-instawork
force-pushed
the
hardin/demo-loaders
branch
from
9419d0d to
573f556
Compare
flochtililoch
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving several visual quirks with Hyperview demo:
Asana