Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-view): support shared cookies #1097

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix(web-view): support shared cookies #1097

merged 1 commit into from
Feb 27, 2025

Conversation

olegpesok
Copy link
Contributor

@olegpesok olegpesok commented Feb 26, 2025

Pass through shared cookies enabled prop for iOS.

Copy link
Collaborator

@flochtililoch flochtililoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the prop you're adding has existed in react-native-webview for 6+ years (PR), so bumping the version might not be necessary. It also appears this prop is iOS only - does the same work on Android without an explicit prop?

Pass through prop to support shared cookies on iOS.
@olegpesok olegpesok changed the title fix(web-view): Bump version + support shared cookies fix(web-view): support shared cookies Feb 27, 2025
@olegpesok
Copy link
Contributor Author

It looks like the prop you're adding has existed in react-native-webview for 6+ years (PR), so bumping the version might not be necessary. It also appears this prop is iOS only - does the same work on Android without an explicit prop?

  • Yes, we don't need to bump the version, that's only for simulator support of this feature.
  • Yes, this works with Android without an additional prop passed through.

@olegpesok olegpesok merged commit b7e0466 into master Feb 27, 2025
6 checks passed
@olegpesok olegpesok deleted the oleg/webview branch February 27, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants