Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(experimental): add support for passing experimental features #1096

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

hgray-instawork
Copy link
Collaborator

Adding support for passing experimental features into Hyperview.

See TAD

Asana

@hgray-instawork hgray-instawork requested a review from a team February 25, 2025 20:46
src/types.ts Outdated
Comment on lines 443 to 445
// Delay the mutation of the navigation state until after the screen has been rendered
// This is intended to improve the performance of navigation actions
navStateMutationsDelay?: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it probably would make more sense to define this in your other PR, to club the change with its relevant refactor.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed: 02c803d

@hgray-instawork hgray-instawork merged commit 99f2b11 into master Feb 26, 2025
6 checks passed
@hgray-instawork hgray-instawork deleted the hardin/experimental-features-support branch February 26, 2025 15:37
hgray-instawork added a commit that referenced this pull request Feb 27, 2025
Resolving the navigation glitch seen in the demo app after updating
`expo` and `react-native`.

Values below 2 showed the glitch always. Values between 2-5 showed the
glitch often. So far a value of 10 has not exhibited the glitch.

| Before | After |
| -- | -- |
|
![before](https://github.com/user-attachments/assets/a20b7aa0-785f-4874-8d7d-d5157de26cfc)
|
![after](https://github.com/user-attachments/assets/b97e2b30-e150-4c59-b5f0-09c42543d38c)
|


Relates to
- #1092
- #1096

[Asana](https://app.asana.com/0/1204008699308084/1209518863613015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants