fix(navigation): resolve performance issue #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flochtililoch
approved these changes
Feb 26, 2025
hgray-instawork
added a commit
that referenced
this pull request
Feb 27, 2025
Resolving the navigation glitch seen in the demo app after updating `expo` and `react-native`. Values below 2 showed the glitch always. Values between 2-5 showed the glitch often. So far a value of 10 has not exhibited the glitch. | Before | After | | -- | -- | |  |  | Relates to - #1092 - #1096 [Asana](https://app.asana.com/0/1204008699308084/1209518863613015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blur,focus, andstatelisteners all can perform heavy dom mutations. Performing them at the same time the screen is rendering and transitioning can cause delays or visual glitches. To resolve, these listeners are delayed a small amount.The use of
setTimeoutenables waiting for the screen to render before mutating the dom. ThenavStateMutationsDelayexperiment value is used to enable the timeout. If the experiment is not set or has a value of "0", no timeout is used. See 35499d9Asana