Uniformize silent kwargs #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tgrandje
commented
Oct 14, 2024
tgrandje
commented
- add silent kwarg to all function using the save_df decorator
- uniformize the default silent value everywhere
- inherit silent values from parent functions everywhere
* add silent kwarg to all function using the save_df decorator * uniformize the default silent value everywhere * inherit silent values from parent functions everywhere
|
tbh, I am not sure that I want everything to be silenced by default |
|
@hadrilec well, I was also not in favor of it, but most queries were already silenced. If we're ok that the default behaviour should be the invert, I'll do it. I still think we should have a consistent API, but that's all. |
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
* simplify _get_credentials and rename it to a more expressive name: retrieve configuration **only** from the latest config file * remove API call checkups from init_conn and transfer it to the new session object (allowing to use quick and dirty patches to emulate a valid connection to all APIs during tests) * ensure any invalid SIRENE key is never stored to the config file, but do not block pynsee if this is invalid as you may want to queries other APIs inly * transfer warnings of os environ variables being used to the new session object and decline these warnings for each config key * prune dead code (_set_sirene_key method) * add tests ensuring new session object's configuration in diverse settings (explicit arg, os.environ or previously saved config file)
getting results triggered the exception, therefore results is not available
|
Just merged inspect-github-timeouts into this PR. We still need to decide whether the default should be silent=True or silent=False for a consistent API. (Either way is ok with me 😉 ) |
|
Note: I cancelled the workflow to avoid having 2 (or 3) at the same time, but we'll need to restart those when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.