-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new catalog module using Melodi API #217
Open
hadrilec
wants to merge
31
commits into
master
Choose a base branch
from
catalog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rm tempdir on _dwn_idbank_file * rm tempfile generated by _get_capabilities * Systemic removal of temp files inside tempdirs Note that some tempdir may still be present as they are generated through lrh_cache. They should be empty anyway. + blackformatting * ignore_errors on shutil.rmtree * Remove unnecessary tempfile * Remove unnecessary tempfile and update idbank ref * Remove unnecessary tempdir from _get_geo_relation * Remove unnecessary tempdir from _get_dataset_dimension * Remove unnecessary tempdir from get_last_release * Remove unnecessary tempdir from _get_insee * Remove unnecessary tempdir from _get_dimension_values * Clean module imports * Remove unnecessary tempdir from _get_geo_list_simple * Remove unnecessary tempdir from _get_dataset_list_internal * Remove unnecessary tempdir from _get_idbank_internal_data * Remove unused module * Add context manager around _download_store_file and _load_data_from_schema * add context manager around _download_store_file and _load_data_from_schema * rewrite _download_store_file to used predefined tempdir and fix docstring * add a TODO in _download_store_file which does NOT used the update argument * add context manager around file for MD5 checksum Nota: started to refactorize this as in-memory read, but had it revert because of the size of involved files (> 4Go), which would be troublesome on old machines * Remove unnecessary tempfile for _get_capabilities * rewrite _get_capabilities to return an io.BytesIO object * update _get_full_list_wfs * Clean up after yourself * Remove unnecessary call to _create_insee_folder and tempfile from _get_file_list_internal * Simplify _create_insee_folder and add a warning on tempfile not beeing cleaned up * Add call to fixed tempdir folder in _import_options * Remove comment
* changes following new API portal * pkg version 0.1.9 + doc update * tests update after new API portal * news + doc update * example nb update + image population france update
…v from GitHub and described in the yml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.