Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/permissions module support #268

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Dec 10, 2024

  • Updated all queries and messages for the Permissions module to support the new module version.
  • Updated examples for the module queries and messages.
  • Refactored the logic to get the compiled protos from the chain and the indexer. Tried to change the logic to compile the protos locally (both for chain and for indexer) but that did not work (the SDK is using more logic than just the compile proto functions). In any case I left the intended new logic (but commented out) in case we want to try this approach again in the future.

NOTE: Do NOT merge this PR until the final version of proto definitions is available

Solves CHAIN-255

Summary by CodeRabbit

Based on the comprehensive summary of changes, here are the high-level release notes:

Release Notes

  • Linter Configuration

    • Updated .golangci.yml to disable the unnamedResult check in the gocritic linter
  • Build Process

    • Refactored Makefile to streamline repository cloning and file copying
    • Updated Buf configuration for protocol buffer generation
  • Module Cleanup

    • Removed several modules and their associated type definitions, including:
      • Auction
      • Insurance
      • Oracle
      • Peggy
      • Permissions
      • Token Factory
      • Stream
  • New Features

    • Added support for contract execution authorization in WasmX module
    • Introduced new utility functions for duplicate detection
    • Enhanced codec registration for various message types
  • Code Optimization

    • Simplified error handling and message validation
    • Removed deprecated interfaces and keeper definitions
    • Streamlined parameter management across modules
  • Deprecation Notice

    • Significant reduction in module-specific type and interface definitions
    • Removed legacy code and unused message types

…dated all examples for that module too. Refactored the logic to update the compiled protos
Copy link

coderabbitai bot commented Dec 10, 2024

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[lintersdb] The name "gas" is deprecated. The linter has been renamed to: gosec."
level=warning msg="[lintersdb] The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused."

Walkthrough

This pull request introduces significant changes across multiple modules in the Injective blockchain codebase. The modifications span various aspects of the system, including removing deprecated files, updating codec registrations, modifying error handling, and introducing new utility functions. The changes appear to be part of a broader refactoring effort to streamline and optimize the codebase, focusing on removing unnecessary code and enhancing existing functionality.

Changes

File Change Summary
.golangci.yml Added "unnamedResult" to disabled checks in gocritic linter
Makefile Replaced copy-exchange-client with clone-injective-indexer and clone-injective-core targets
buf.gen.chain.yaml, buf.gen.indexer.yaml New configuration files for Protocol Buffers generation
Multiple chain/*/types/ files Removed deprecated files for auction, insurance, oracle, peggy, permissions, and tokenfactory modules
chain/codec/codec.go Added codec.RegisterEvidences(cdc)
chain/exchange/types/ Added new methods, message types, and error handling
chain/helpers/common.go Added generic duplicate checking functions
chain/types/util.go Added duplicate checking utility functions
chain/wasmx/types/ Added new authorization-related types and codec registrations

Poem

🐰 Refactoring Rabbit's Rhapsody 🐰

Through modules old and files so stale,
We hop and trim without travail,
Cleaning code with bunny might,
Making systems lean and bright!

hop hop 🥕

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aarmoa aarmoa changed the base branch from master to dev December 10, 2024 15:06
…dated all examples for that module too. Refactored the logic to update the compiled protos
…ve an issue with the latest gRPC version (v1.64.1 vs v1.63.2)
…ns (candidate versions for the next release)
…used for the v1.14 Testnet upgrade. Included the new fields and endpoints in the SDK API components and updated the example scripts
@aarmoa aarmoa marked this pull request as ready for review January 20, 2025 15:09
@aarmoa aarmoa merged commit 6bf611d into dev Jan 20, 2025
4 checks passed
@aarmoa aarmoa deleted the feat/permissions_module_support branch January 20, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant