v12 SRF (per-chunk PDC support, no double-compression); fix bad bug causing chunks go poof. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties and entities. Fix horrible bug which made chunks go poof.
|
Could Issue #5 be implemented with the custom chunk compound tags as well? 🤔 |
|
In the current implementation, your patch 0011 clashes with the already existing patch 0011-Make-SlimeWorld-a-PersistentDataHolder in the 1.20.4 version |
hm, that one ain't from 1.20.4, but from main. Gonna do a quick rebase! |
|
Done, thanks for the tip |
Paul19988
requested changes
Dec 30, 2023
core/src/main/java/com/infernalsuite/aswm/serialization/anvil/AnvilWorldReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/infernalsuite/aswm/serialization/anvil/AnvilWorldReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/infernalsuite/aswm/serialization/slime/SlimeSerializer.java
Outdated
Show resolved
Hide resolved
...va/com/infernalsuite/aswm/serialization/slime/reader/impl/v12/v12SlimeWorldDeSerializer.java
Outdated
Show resolved
Hide resolved
...va/com/infernalsuite/aswm/serialization/slime/reader/impl/v12/v12SlimeWorldDeSerializer.java
Outdated
Show resolved
Hide resolved
...va/com/infernalsuite/aswm/serialization/slime/reader/impl/v12/v12SlimeWorldDeSerializer.java
Outdated
Show resolved
Hide resolved
patches/server/0012-Add-v12-chunk-pdc-and-extra-nbt.-Fix-double-compress.patch
Outdated
Show resolved
Hide resolved
patches/server/0012-Add-v12-chunk-pdc-and-extra-nbt.-Fix-double-compress.patch
Outdated
Show resolved
Hide resolved
…AnvilWorldReader.java Co-authored-by: Paul <Paul19988@users.noreply.github.com>
Paul19988
approved these changes
Dec 30, 2023
|
@Paul19988 @kyngs Ty for the var changes |
ComputerNerd100
approved these changes
Dec 30, 2023
ComputerNerd100
pushed a commit
that referenced
this pull request
Jan 9, 2024
…ausing chunks go poof. (#91) * Add v12, chunk pdc and extra nbt. Fix double compression on tile entities and entities. Fix horrible bug which made chunks go poof. * Quick rebase on main * Fix entity loading bug. (Authored by @AverageGithub) * Fix entity loading bug. (Authored by @AverageGithub) * Fix a bug with the extra tag being empty. * Yeet debug logs * Fix crash. (Authored by @AverageGithub) * Update core/src/main/java/com/infernalsuite/aswm/serialization/anvil/AnvilWorldReader.java Co-authored-by: Paul <Paul19988@users.noreply.github.com> * Paul doesn't like var :( * Review changes --------- Co-authored-by: kyngs <kyngs@users.noreply.github.com> Co-authored-by: Paul <Paul19988@users.noreply.github.com>
shoker537
pushed a commit
to MinigamesNetwork/AdvancedSlimePufferfish
that referenced
this pull request
May 18, 2024
…ausing chunks go poof. (InfernalSuite#91) * Add v12, chunk pdc and extra nbt. Fix double compression on tile entities and entities. Fix horrible bug which made chunks go poof. * Quick rebase on main * Fix entity loading bug. (Authored by @AverageGithub) * Fix entity loading bug. (Authored by @AverageGithub) * Fix a bug with the extra tag being empty. * Yeet debug logs * Fix crash. (Authored by @AverageGithub) * Update core/src/main/java/com/infernalsuite/aswm/serialization/anvil/AnvilWorldReader.java Co-authored-by: Paul <Paul19988@users.noreply.github.com> * Paul doesn't like var :( * Review changes --------- Co-authored-by: kyngs <kyngs@users.noreply.github.com> Co-authored-by: Paul <Paul19988@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add per-chunk PDC support.
To test this functionality, one can use the plugin I've coded for this https://github.com/kyngs/ASP-PDCTest/tree/pr90
@ComputerNerd100 raised concerns about how I wrap NMSChunk around the original SlimeChunk, so please review that.
This is a bigger PR, so there may be some bugs, I've done a lot of testing tho.
Hopefully I didn't forget anything.