Add a search button in New Tab #1801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
felipeerias
force-pushed
the
felipeerias/newTabSearch
branch
2 times, most recently
from
834ad3b to
2c89ea1
Compare
|
As a general comment it looks weird to have a button that focus the URL bar. Desktop browsers normally include a text field that redirects the search to the default web engine. At least that's why I expect. |
felipeerias
force-pushed
the
felipeerias/newTabSearch
branch
from
2c89ea1 to
c0d9f0b
Compare
This was referenced Mar 12, 2025
felipeerias
force-pushed
the
felipeerias/newTabSearch
branch
from
c0d9f0b to
80771dc
Compare
|
|
Add a button in New Tab that, when clicked, opens the Search bar and the keyboard.
felipeerias
force-pushed
the
felipeerias/newTabSearch
branch
from
80771dc to
c30d421
Compare
|
@felipeerias should we abandon this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1800
Add a button in New Tab that, when clicked, focuses the Search bar and opens the keyboard. This is similar to how the search entry works on browsers like Firefox.