Use Requests for mutli-part POST, project organisation to allow installation with pip, more test coverage & fixed tests #22
+579
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiphiphiphip
changed the title
added 8 commits
April 20, 2015 17:03
- Renamed and moved modules into a Python package. - Added an __init__.py to make importing smoother. - Added '.txt' to requirements as per pip's documentation. - Created a setup.py. This needs reviewing! - Generated a package manifest. - Modified the README to give the new installation instructions. (This needs checking after pull request!) - Moved the user-facing script into bin directory so that pip will automagically install it in the correct place and chmod it for use. - Updated the shebang line in bin/pythonbits from 'python' to 'python2' to prevent the wrong interpreter being selected on hipster Linux distributions that ship with python3 as system /usr/bin/python.
- Added Makefile to automate quick test/install/uninstall & separate requirements.txt for testing dependencies - Added tests for upload function; added mocking dep 'responses' to requirements - Added test cases for taking screenshots with ffmpeg & tiny tiny video as test fixture; added 'mock' to requirements - moved & renamed pythonbits/TvdbUnitTests.py to make the testrunner find it - Updated Tvdb_test to pass, but needs refocusing to test just the interface, not the underlying tvdb lib.
hiphiphiphip
changed the title
|
I'm sorry this isn't all beautifully atomic pull requests. |
added 4 commits
April 21, 2015 16:07
Replaced tests for Tvdb_test.py with ones that test the interface instead of testing if tvdb_api objects contain the keys and values they contained from the time the tests were first written. Also they are no longer dependent on the network.
- Complete with tests. - Updated requirements & seup.py to pull new imdbpie. - Rewrote ImdbParser module as movie module. - Moved movie summary generating code to movie. - Updated MANIFEST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project already drags in Requests, so it may as well use the multi-part POST handling. 60e01a3 is mostly cosmetic, but cleans up error handling and creating the dump file.