Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› ๏ธ ๋ฆฌํŒฉํ† ๋ง : CQRS ํŒจํ„ด Read ๋ ˆํฌ์ง€ํ† ๋ฆฌ ๋ถ„๋ฆฌ ์ž‘์—… ๋ฐ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€ #178

Merged
merged 1 commit into from
Nov 26, 2024
Merged

๐Ÿ› ๏ธ ๋ฆฌํŒฉํ† ๋ง : CQRS ํŒจํ„ด Read ๋ ˆํฌ์ง€ํ† ๋ฆฌ ๋ถ„๋ฆฌ ์ž‘์—… ๋ฐ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€ #178

merged 1 commit into from
Nov 26, 2024

Conversation

hanseu9839
Copy link
Collaborator

  1. ์ „์ฒด ๊ตฌ์กฐ ๋ฆฌํŒฉํ† ๋ง ๋ฐ ๋ถˆํ•„์š”ํ•œ QueryDSL ๊ตฌ๋ฌธ์„ ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค.

  2. @EqualsAndHashCode ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ AuditingFields์— ์žˆ๋Š” ํ•„๋“œ ๊ฐ’์„ ๋น„๊ตํ•˜์ง€ ์•Š๋„๋ก ๊ตฌํ˜„

  3. DataJpaTest ๋ฅผ ํ†ตํ•œ findAllByResumeId ๋ฉ”์†Œ๋“œ ๊ฒ€์ฆ

@hanseu9839 hanseu9839 added the ๐Ÿ› ๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง label Nov 26, 2024
@hanseu9839 hanseu9839 self-assigned this Nov 26, 2024
@hanseu9839 hanseu9839 merged commit 1a7a487 into main Nov 26, 2024
1 check passed
rowing0328
rowing0328 reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@rowing0328 rowing0328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowing0328 rowing0328 rowing0328 left review comments

@parkswon1 parkswon1 Awaiting requested review from parkswon1

@Aleph-Kim Aleph-Kim Awaiting requested review from Aleph-Kim

Assignees

@hanseu9839 hanseu9839

Labels
๐Ÿ› ๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanseu9839 @rowing0328