Add timeout to MDANSE unit tests #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
The problem, of course, being that this is an intermittent failure not limited to any particular Python version.
Doesn't seem to have happened, but at worst this should be a slight preventative measure which should allow us to find out what's actually going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Following the discussion of #673 we add timeout to unit tests.
Fixes
Added pytest-timeout to the workflow.
Set tests timeout in pyproject.toml.
To test
Tests should pass same as before.