Use pytest for test_units
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor _Unit class to use dunders better
MDANSE/Src/MDANSE/Framework/Units.py
Outdated
| """Ceil of a _Unit value in canonical units. | ||
|
|
||
| >>> print(measure(10.2, 'm/s').ceiling()) | ||
| 10.0000 m / s |
There was a problem hiding this comment.
I know that these docstrings were already written like this before you made changes, but I think that the examples given here are wrong.
The docstrings below for __floor__ and __round__ should be checked too.
Overall, I would expect 3.6 m/s to be 12.96 km/h, and the ceil, round, floor to give 13, 13 and 12, respectively.
There was a problem hiding this comment.
Reworked the docstrings throughout and made sure it was valid under doctest.
oerc0122
force-pushed
the
pytestise-units
branch
from
a71db07 to
c389fde
Compare
oerc0122
force-pushed
the
pytestise-units
branch
from
c389fde to
2590a38
Compare
MBartkowiakSTFC
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Equivalencesdict withdefaultdictFixes
N/A
To test
Standard tests