Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Investigate removing IOutputVariable and subclasses #698

Open
oerc0122 opened this issue Mar 4, 2025 · 0 comments
Open

[ENHANCEMENT] Investigate removing IOutputVariable and subclasses #698

oerc0122 opened this issue Mar 4, 2025 · 0 comments
Labels
enhancement New feature or request Technical Debt Legacy code which should be cleaned up.

Comments

@oerc0122
Copy link
Collaborator

oerc0122 commented Mar 4, 2025

Is your feature request related to a problem? Please describe.
The MDANSE.Framework.OutputVariables.IOutputVariable and subclasses (LineOutputVariable, SurfaceOutputVariable and VolumeOutputVariable) and associated OutputData object seem to be vestigial objects.

Describe the solution you'd like
It may be possible to either remove them entirely or replace them with standard xarray data. xarray integrates seamlessly with dask (see #443), h5py, matplotlib and pint and provides the metadata features which IOutputVariable attempts to include.

Describe alternatives you've considered
N/A

Additional context
N/A

@oerc0122 oerc0122 added enhancement New feature or request Technical Debt Legacy code which should be cleaned up. labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Technical Debt Legacy code which should be cleaned up.
Projects
None yet
Development

No branches or pull requests

1 participant