Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Replace Rotations with scipy #690

Open
oerc0122 opened this issue Mar 4, 2025 · 0 comments
Open

[ENHANCEMENT] Replace Rotations with scipy #690

oerc0122 opened this issue Mar 4, 2025 · 0 comments
Labels
Technical Debt Legacy code which should be cleaned up.

Comments

@oerc0122
Copy link
Collaborator

oerc0122 commented Mar 4, 2025

Is your feature request related to a problem? Please describe.
MDANSE.Mathematics.LinearAlgebra.Quaternion is used in three places:

  • As a return from MANSE.Mathematics.Transformation.Rotation.asQuaternion
  • As a return from MANSE.Mathematics.superposition_fit
  • As a return from RigidBodyTrajectoryGenerator (which is being deprecated?)

Describe the solution you'd like
Scipy provides established classes for handling rotations including quaternions.

These methods should be reworked to use these classes to remove maintenance responsibilities.

Describe alternatives you've considered
N/A

Additional context
N/A

@oerc0122 oerc0122 added the Technical Debt Legacy code which should be cleaned up. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Legacy code which should be cleaned up.
Projects
None yet
Development

No branches or pull requests

1 participant