Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Rename Box and Real configuration types #679

Open
oerc0122 opened this issue Feb 24, 2025 · 0 comments
Open

[ENHANCEMENT] Rename Box and Real configuration types #679

oerc0122 opened this issue Feb 24, 2025 · 0 comments
Labels
enhancement New feature or request Technical Debt Legacy code which should be cleaned up.

Comments

@oerc0122
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There is a standard name in crystallography for Box (fractional) and Real (absolute/cartesian) coordinates. Having these MDANSE-only names is confusing. (c.f https://en.wikipedia.org/wiki/Fractional_coordinates)

Describe the solution you'd like
Standardise all names to Frac/Abs when referring to those properties.

In the first instance to maintain backwards compatibility leave aliases to old names.

Describe alternatives you've considered
N/A

Additional context
N/A

@oerc0122 oerc0122 added the enhancement New feature or request label Feb 24, 2025
@oerc0122 oerc0122 added the Technical Debt Legacy code which should be cleaned up. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Technical Debt Legacy code which should be cleaned up.
Projects
None yet
Development

No branches or pull requests

1 participant