Fix the order of fields on the AdvancedSearch Page

[PaulBoon]

What this PR does / why we need it:
Have advanced search page use a query that orders by displayOrder before id, so that it will use the displayOrder if available instead of ignoring it.

Which issue(s) this PR closes:

• Closes Advanced search page does not use the display order of the metadata fields #11272

Special notes for your reviewer:

Suggestions on how to test this:
Use a custom metadata block (tsv file) and change the order in a way that it is different from the rows order in the file, like change the last one to have order 0.
Then load that tsv and check the advanced search page, before the fix it would not be at the top, but after the fix it will be.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 22.736%. remained the same
when pulling d72766a on PaulBoon:IQSS/11272-FixOrderOnAdvancedSearchPage
into 2210d16 on IQSS:develop.

[qqmyers]

Since displayOrder is within the metadatablock, should this be order by metadatablock_id, displayOrder to keep things ordered by block, using displayOrder within the block? Is order by o.id still needed?

[PaulBoon]

I would keep o.id because that is a fallback when the displayOrder is the same and what has been used thus far.
Not sure about the metadatablock_id, because I don't expect the fields start moving to other blocks if we don't use it in ordering.
I mean, it does not change the advanced search page, it might be nice for someone debugging the code and watching the result of the query.

[qqmyers]

Ahh - I see the code pulls things out per block after this query:

dataverse/src/main/java/edu/harvard/iq/dataverse/search/AdvancedSearchPage.java

Lines 76 to 87 in 2210d16

	this.metadataFieldList = datasetFieldService.findAllAdvancedSearchFieldTypes();
	for (MetadataBlock mdb : metadataBlocks) {
	List<DatasetFieldType> dsfTypes = new ArrayList<>();
	for (DatasetFieldType dsfType : metadataFieldList) {
	if (dsfType.getMetadataBlock().getId().equals(mdb.getId())) {
	dsfTypes.add(dsfType);
	}
	}
	metadataFieldMap.put(mdb.getId(), dsfTypes);
	}

so no need to sort by block here.

[qqmyers]

Looks fine to me. I would suggest adding a one line release note though, e.g. - metadata fields on the Advanced Search page are now shown in display order.

[jggautier]

Looks fine to me. I would suggest adding a one line release note though, e.g. - metadata fields on the Advanced Search page are now shown in display order.

Would this include the Persistent ID and Publication Date fields?

that we see on the dataset page's Metadata tab but that are not configurable with the metadata block TSV files?

When viewing the Citation Metadata on the dataset page's Metadata tab, those fields appear at the top:

But they're "system generated" metadata and not configurable with the Citation metadata block TSV file, and they're at the bottom of the Advanced Search page:

[jggautier]

I should mention that I'm really interested in a discussion, even just a brief one here, that helps me understand if the order of those two fields will change when users see the Advanced Search page, and I'm not necessarily suggesting that this PR be changed to reorder those two fields.