discarded code that will never be reached #11211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffritze thanks, as I mentioned in Zulip I put this in the "Sonar Qube cleanup (Gustavo)" column: https://github.com/orgs/IQSS/projects/34/views/1 |
|
@pdurbin Hi Phil, you have asked in Zulip if I would like to have this pull request in 6.6. It is no feature but it just cleans the code. So maybe it's already in the dev pipeline. Otherwise I would recommend to merge it into 6.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There is an interference between code fixing this issue #10472 and my already merged pull request: #10764
My code is reached, the code for the issue probably does the same but is never reached so I have deleted it in my pull request branch to clean up the code.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: