-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy and test use of "guestbook at request" feature on Demo Dataverse #247
Comments
For more context, I'm adding a link to the email conversation that prompted this GitHub issue, where folks planning to use Harvard Dataverse expressed interest in what the "guestbook at request" feature would let them do. The email conversation is at https://help.hmdc.harvard.edu/Ticket/Display.html?id=357131 |
@jggautier could you clarify what is meant by investigate here, beyond configuring HDV? |
In a Slack conversation on Feb. 20, @sbarbosadataverse wrote about wanting "to confirm it's working exactly as you described" |
@jggautier Is the recommendation then to turn on in demo first to confirm, then HDV if the feature behaves as expected? |
I'm not sure what @sbarbosadataverse had in mind. Maybe adding this functionality to Demo Dataverse or maybe to an AWS instance so that @sbarbosadataverse can review it? Or maybe it'll be helpful for @sbarbosadataverse to review documentation related to the functionality and the results of any UX research that was done when it was being worked on? @sbarbosadataverse what do you think? |
Yes, let's move to demo and I can actively review and test. |
There might be some conversation happening soon in a thread in the Dataverse Users Community Google Group about using this feature. |
Just following up on this after reviewing my conversation with the user who's interested in this feature. When this is picked up for a sprint and a developer can add this feature to Demo Dataverse, I imagine we'd like it configured so that by default it's turned off for all collections. And collection admins can turn it on the way Jim described in that Google Groups thread. |
Just noting here some GitHub issues describing recent changes and possible changes to the way this feature works:
|
Might be helpful to keep an eye on a recent Zulip thread where the manager of another Dataverse installation is asking questions about configuring the "guestbook at request" feature. |
@dliburd and I had a quick chat about this in the context of https://help.hmdc.harvard.edu/Ticket/Display.html?id=369533 I signed up for an account on ADA (where this feature is on) so I could see what the UX is like when you click "Request Access" on this file, for example: https://dataverse.ada.edu.au/file.xhtml?fileId=19166&datasetVersionId=3979 Here are some screenshots: As you can see, the guestbook is shown. Dwayne and I agree that this behavior is quite nice! As for trying this on demo, judging from https://guides.dataverse.org/en/6.4/installation/config.html#dataverse-files-guestbook-at-request we have a couple options:
If we go with the latter option, whoever picks up this issue would need to know which collections to turn on "guestbook at request", of course. |
@jggautier |
FWIW: With that setting true, the default changes to using guestbook-at-request. The setting can be changed per collection (on the Edit/General Settings tab) or per dataset (via API) as well. For Harvard Dataverse, one option would be to set the setting false to keep the current default while still allowing guestbook-at-request to be turned on for specific collections. |
Thanks. @sbarbosadataverse and @kmika11 are talking about testing. |
2025/01/15: Placing on hold until Sonia and Katie complete testing. Julian will confirm with them. |
This feature only affects whether a guestbook, if assigned to a dataset, is shown when the user requests data access or when they download. Is there something we should add to the text/help text to make that clearer? Or is there a case you're seeing a guestbook appear when you think it shouldn't? (FWIW: I think a ~guestbook dialog appears if there are custom terms/terms of access in a dataset, intended to assure that users see those terms (either at request access or download time now) before they get the data, even if there is no guestbook assigned to the dataset.) |
Ah! I see! I do think the limited info on the create/edit dataverse page and the way the tool tip is worded makes it sound like the only options an author has is between applying a guestbook at download or at request. Perhaps some short text under or with the feature label like "For datasets with enabled guestbooks..." would help clarify that this only applies to specific datasets? |
I think that's a bug - I've created a PR #11203 to fix that and another issue (terms of access don't appear if you use the per-file download menu in the table (instead of selecting a file and hitting the request access button at the top). I also made minor changes to call the collection/general info/edit option "Guestbook Mode" and to have help that includes "(when configured for a dataset)". Easy to edit that as it gets reviewed. |
Overview
After the 6.5 release:
Note that sizing only covers deployment on demo; curation testing will occur separately.
The text was updated successfully, but these errors were encountered: