Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed geoserver from the chart #82

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented Nov 30, 2023

Removed geoserver from the chart. This is also tied with the PR in ncsa chart ncsa/charts#16
The changes are deployed in dev and tst cluster. The geoserver is also deployed using the ncsa's geoserver chart. The geoserver and data preview works well in dev cluster.

@ywkim312 ywkim312 linked an issue Nov 30, 2023 that may be closed by this pull request
@ywkim312 ywkim312 self-assigned this Nov 30, 2023
@ywkim312 ywkim312 requested a review from robkooper November 30, 2023 21:27
README.md Outdated
@@ -104,6 +104,9 @@ For an example of using existing PVC, see the file [incore-pvc.yaml](incore-pvc.

## ChangeLog

### 1.22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make a release branch for this, and not merge into main. We will have a release soon, and we should document how this will change the deployment.

Copy link
Member Author

@ywkim312 ywkim312 Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to merge it to develop. Then I will create a release branch out of develop when the release happens. So my original plan was to release this one as 1.22.0 and the next incore release to the next incore-helm release. But maybe we can include this one and the next incore release together in the same release version.

@ywkim312 ywkim312 changed the base branch from main to develop December 1, 2023 16:47
@robkooper
Copy link
Member

I think the trick is to get this deployment with the real geoserver on incore-dev first and see if that works.

@ywkim312
Copy link
Member Author

ywkim312 commented Dec 1, 2023

I think the trick is to get this deployment with the real geoserver on incore-dev first and see if that works.

The current dev instance is deployed with this PR. Also geoserver is deployed using the NCSA chart one. I have tested the geoserver instance itself, and using incore's data viewer and incore services and all works well

I think the trick is to get this deployment with the real geoserver on incore-dev first and see if that works.

This helm chart has been deployed to dev and also the ncsa/chart's geoserver is also deployed in the dev.
Tested the preview using the data viewer and it worked well
Posting new dataset also successfully pushed the dataset to geoserver so it can be served to dataviewer.

@robkooper robkooper merged commit 0354d8a into develop Dec 6, 2023
@ywkim312 ywkim312 deleted the 75-separated-geoserver-from-incore-helm-chart branch December 13, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separated geoserver from incore helm chart
2 participants