Feat/config events #626
Open
Feat/config events #626
+1,540
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocruze
approved these changes
Jan 27, 2025
tonai
force-pushed
the
feat/config-events
branch
from
a35ac10 to
100a8fd
Compare
tonai
force-pushed
the
feat/config-events
branch
from
100a8fd to
66e9b7e
Compare
tonai
force-pushed
the
feat/config-events
branch
from
8d52395 to
665db4c
Compare
slafayIGN
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Merci, ça fonctionne super bien !
Je te demande toutefois quelques renommages sur les routes pour les avoir en français comme sur le reste du site et une réorganisation de la page niveau de service pour mieux en hiérarchiser le contenu et avoir l'accès au RSS.
|
Aussi lorsque les titres des alertes sont un peu long (ce qui est facilement le cas), le tableau a un scroll horizontal et les boutons de modification et suppression se retrouvent cachés. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrige #618
Il manque encore:
integration texte riche pour le détailflux RSSon n'affiche pas le lien pour aller sur la page de configuration, mais il n'y a pas d'affichage de page 403 si on rentre manuellement l'URL et que l'on a pas les bons droits (pas accès à l'entrepôt ou pas le droit annexe) => nécessite un rework global pour résoudre ce pointAutres points:
cache: "no-store"pour charger le fichiers des alertes et éviter d'utiliser le cache navigateur qui pose problème