Skip to content

Use logger.warning instead of logger.error for validation errors #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tnagorra
Copy link
Member

No description provided.

Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also used to create multiple issues in Sentry!

@subinasr
Copy link
Contributor

@tnagorra Is there a reason we're using warnings for transformation failures as well?

@tnagorra
Copy link
Member Author

After implementing support for partial success, there can be a flood of transformation errors.
If we use logger.error, all of these are sent to Sentry and this can easily overwhelm the infrastructure (also introduce noise)

logger.warning is not sent to Sentry and we can refer to the logs for transformation errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants