Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: Move field report title generation logic to server #1470

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

samshara
Copy link
Member

@samshara samshara commented Nov 14, 2024

Addresses:

Depends on:

Changes

  • Removed title generation logic from the client, including the handling of prefixes and suffixes.
  • The title field will now store the user-provided title for the field report.
  • The summary field will contain the automatically generated title from the server.

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: f719b53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

app/src/views/FieldReportForm/ContextFields/index.tsx Outdated Show resolved Hide resolved
app/src/views/FieldReportForm/common.ts Outdated Show resolved Hide resolved
@samshara samshara force-pushed the fix/field-report-title-server-generation branch from 3348e90 to 0b136d2 Compare December 26, 2024 05:27
@tnagorra tnagorra changed the title Move field report title generation logic to server Project: Move field report title generation logic to server Dec 27, 2024
@tnagorra tnagorra changed the title Project: Move field report title generation logic to server project: Move field report title generation logic to server Dec 27, 2024
@samshara samshara force-pushed the fix/field-report-title-server-generation branch from 2d48508 to dcd13d3 Compare January 3, 2025 05:52
@frozenhelium frozenhelium dismissed tnagorra’s stale review January 29, 2025 09:17

Requested changes has been implemented

@frozenhelium frozenhelium merged commit 0d0e5d6 into develop Jan 29, 2025
16 checks passed
@frozenhelium frozenhelium deleted the fix/field-report-title-server-generation branch January 29, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants