Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate stats generation in country page #2173

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

k9845
Copy link
Contributor

@k9845 k9845 commented Jun 13, 2024

Addresses

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@k9845 k9845 force-pushed the feature/fix-country-stats branch from a2aa1b4 to 4257d5a Compare June 13, 2024 10:25
@k9845 k9845 marked this pull request as ready for review June 13, 2024 10:28
@k9845 k9845 force-pushed the feature/fix-country-stats branch 7 times, most recently from 4615fd9 to 89f1bfb Compare June 20, 2024 09:40
@szabozoltan69
Copy link
Contributor

The class AppealViewset should not use queryset = Appeal ... instead of queryset = AppealHistory.
This way the importance and meaning of appealhistory goes to null.
You should reduce the counts somehow else.

Add proper valid_from, valid_to filters
@thenav56
Copy link
Member

Hey @szabozoltan69 This PR is ready, Could you review again and deploy it to staging?

@szabozoltan69 szabozoltan69 merged commit 6e79a94 into develop Jun 21, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/fix-country-stats branch June 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants