New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make resource requirements for CronJob per job #2181

Open

batpad opened this issue Jun 21, 2024 · 0 comments

Labels

feature

Collaborator

batpad commented Jun 21, 2024

Allow CronJobs to define their own resource requirements, so we don't need to have the same resources for all cronjobs. Currently resource requirements for CronJobs are specified as a fixed value here: https://github.com/IFRCGo/go-api/blob/develop/deploy/helm/ifrcgo-helm/templates/cronjobs/jobs.yaml#L31

Instead, we should allow each cronjob to over-ride this value, so each cronjob could define a resources in addition to schedule: https://github.com/IFRCGo/go-api/blob/develop/deploy/helm/ifrcgo-helm/values.yaml#L120 to specify over-rides - for cronjobs that may require a lot of resources, for example.

cc @szabozoltan69 @sunu

(let's not work on this right now until the infra changes, but just ticketing so that we do it soon - it should be pretty straightforward)

The text was updated successfully, but these errors were encountered:

batpad added the feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment