Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a per export type in the server and generate the PER Country page preparedness tab PDF export #1998

Closed
samshara opened this issue Jan 16, 2024 · 0 comments
Assignees

Comments

@samshara
Copy link
Member

samshara commented Jan 16, 2024

I suggest we also refactor the export endpoint as following
The client sends only the following information

  • export_type
  • identifier

The server should have a static configuration to save information regarding exports
For example

.... and others

  1. We also need to support a white list for the client field, as of right now it can be anything as configured in the client.
  2. We also need a separate environment variable on the client side to determine if we must use the currently deployed front-end for export. This can be true only for the testing environment.
    The PDF export could have a security vulnerability as explained in https://blog.projectdiscovery.io/abusing-reverse-proxies-metadata/

cc @thenav56

@samshara samshara transferred this issue from IFRCGo/go-web-app Jan 16, 2024
@k9845 k9845 mentioned this issue Jan 16, 2024
2 tasks
@k9845 k9845 mentioned this issue Feb 27, 2024
18 tasks
@tovari tovari closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants