Clear fileName of index objects when hasName triple is removed
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggVGc
force-pushed
the
valter/fix-index-delete-hasName
branch
from
b3e01b0 to
2c0302c
Compare
ggVGc
changed the title
fName in index when triple is removedfName in index when hasName triple is removed
ggVGc
changed the title
fName in index when hasName triple is removedfileName of index objects when hasName triple is removed
emmaicos
reviewed
Feb 4, 2025
src/main/scala/se/lu/nateko/cp/meta/services/sparql/magic/index/IndexData.scala
Outdated
Show resolved
Hide resolved
src/test/scala/se/lu/nateko/cp/meta/test/services/sparql/index/IndexDataTest.scala
Show resolved
Hide resolved
src/test/scala/se/lu/nateko/cp/meta/test/services/sparql/index/IndexDataTest.scala
Show resolved
Hide resolved
ggVGc
force-pushed
the
valter/fix-index-delete-hasName
branch
from
55a73af to
3392d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue which was found when enabling the
-Wvalue-discardoption.In short, currently if an object has a
hasNameassociation which is later removed, the value is not actually updated in the in-memory index. This would be corrected upon next service restart when the the IndexData instance is rebuilt (since the bug is only in the index, not the actual triple store).The fix probably has negligible real-world effects, but I used it as a way to get more familiar with the workings of the
IndexDatacode.In order to reduce the surface area of the IndexData interface, I also added a trait
StatementSourceincluding the subset ofTripleStoreConnectionrelating only to reading existing statements.