Improve logging context by using local logger instances #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eredMetaSource, MidLowCostsMetaSource, CitationClient, Main
emmaicos
approved these changes
Jan 28, 2025
src/main/scala/se/lu/nateko/cp/meta/services/citation/CitationClient.scala
Show resolved
Hide resolved
src/main/scala/se/lu/nateko/cp/meta/services/labeling/LifecycleService.scala
Outdated
Show resolved
Hide resolved
src/main/scala/se/lu/nateko/cp/meta/metaflow/TriggeredMetaSource.scala
Outdated
Show resolved
Hide resolved
This was referenced Jan 28, 2025
ggVGc
force-pushed
the
valter/local-loggers
branch
from
90e6530 to
228619d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #280.
Improves logging by instantiating loggers in modules, rather than using the logger from the root
ActorSystemdirectly, which improves context of log messages.Along the way, I have also removed some unused imports and unused local values.
In the cases where a class was only using an
ActorSystemfor logging, I have opted for using theslf4jinterface directly, like:val log = LoggerFactory.getLogger(getClass())