HC optimization finalization - phase 3 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom connectivity properties. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…ding to more condensed optimized output. Signed-off-by: Tanya <tatyana@il.ibm.com>
…to account TCP/non-TCP protocol restriction. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping. Signed-off-by: Tanya <tatyana@il.ibm.com>
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…e properties in containing connections. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping. Added grouping by full IpBlock. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…neration of dot output in optimized solution Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
… optimized runs Signed-off-by: Tanya <tatyana@il.ibm.com>
… optimized fw-rules minimization algorithm. Fixed get_connection_set_and_peers_from_cube. Changed some of the expected results of semantic diff tests. Signed-off-by: Tanya <tatyana@il.ibm.com>
Updated more semantic diff expected results. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
… into opt-finalize2
Signed-off-by: Tanya <tatyana@il.ibm.com>
…les minimization) only if the number of peers is not too high, to avoid long run of these auto-connections calculation. Signed-off-by: Tanya <tatyana@il.ibm.com>
…in test schemes (instead of putting them only in configurations), to avoid trying to load resources from live cluster, which is time-consuming. Signed-off-by: Tanya <tatyana@il.ibm.com>
Changed number of expected warnings (see Issue #724 Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Fixed small error. Signed-off-by: Tanya <tatyana@il.ibm.com>
Consequently, fixed expected results Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Small fix in printing TCP connections in dot format. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…tivityProperties. Removed outdated unit tests. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Removed --optimized_run flag. Removed ConnectionSet class. Signed-off-by: Tanya <tatyana@il.ibm.com>
Removed original-to-optimized-comparison workflows from test-push. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking optimized vs. non-optimized implementation. Fixing long runs.
Cleaning up non-optimized code.