Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Cloud Connection Resource #5910

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[Refactor] Cloud Connection Resource #5910

merged 1 commit into from
Jan 15, 2025

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Jan 9, 2025 •
edited
Loading

Output from acceptance test:

--- PASS: TestAccIBMPICloudConnectionbasic (337.04s)
PASS
--- PASS: TestAccIBMPICloudConnectionClassic (396.08s)
PASS
--- PASS: TestAccIBMPICloudConnectionNetworks (411.06s)
PASS
--- PASS: TestAccIBMPICloudConnectionVPC (401.47s)
PASS
--- PASS: TestAccIBMPICloudConnectionTransitGateway (339.61s)
PASS

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Jan 9, 2025
@ismirlia ismirlia changed the title Refactor Cloud Connection [Refactor] Cloud Connection Resource Jan 9, 2025
@ismirlia ismirlia mentioned this pull request Jan 9, 2025
Closed
@ismirlia ismirlia force-pushed the refactor-cloud-conneciton-v2 branch from f5b47e9 to f93f16a Compare January 9, 2025 19:22
@ismirlia ismirlia requested review from yussufsh and hkantare January 9, 2025 19:22
yussufsh
yussufsh previously approved these changes Jan 13, 2025
View reviewed changes
@ismirlia ismirlia force-pushed the refactor-cloud-conneciton-v2 branch from f93f16a to 25049a6 Compare January 13, 2025 22:31
@ismirlia ismirlia requested a review from yussufsh January 13, 2025 22:31
@yussufsh yussufsh merged commit 1993b1a into IBM-Cloud:master Jan 15, 2025
1 check passed
@yussufsh yussufsh deleted the refactor-cloud-conneciton-v2 branch January 15, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@michaelkad michaelkad Awaiting requested review from michaelkad

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismirlia @yussufsh